Closed trvrb closed 2 weeks ago
Ideally here we'd have the simple system of Auspice config override that's been discussed before
Yes (we've all agreed to this in principle many times before, someone just needs to work out the details of how merging works). Unfortunately we can't use command line arguments to override the display_defaults
.
I can implement a temporary solution tomorrow (or thereabouts) where we add a rule auspice_config:
and modify things conditional on wildcards.
Thanks James! No real urgency here. I just added the divergence outliers to the dropped strains list: https://github.com/nextstrain/avian-flu/commit/e98c98c90bee706622ca70d91c809bebcddcda21, so this should clean up the default divergence in the interim.
We had swapped the default
h5n1-cattle-outbreak
view to be divergence rather than time tree due to the previously excessive extrapolation from divergence to time via molecular clock because of lack of metadata on SRA. However, at this point we have three things going on:I'd propose that we swap default
distance_measure
here: https://github.com/nextstrain/avian-flu/blob/master/config/h5n1-cattle-outbreak/auspice_config_h5n1-cattle-outbreak.json#L127, back tonum_date
.However, this should only be done for https://nextstrain.org/avian-flu/h5n1-cattle-outbreak/genome, the segment-level trees like https://nextstrain.org/avian-flu/h5n1-cattle-outbreak/ha should keep divergence as default.
This is kind of annoying in that I'd like to avoid 9 different Auspice configs keyed to different wildcards.
Ideally here we'd have the simple system of Auspice config override that's been discussed before
cc @jameshadfield