nextstrain / conda-base

Conda package build for nextstrain-base

https://anaconda.org/Nextstrain/nextstrain-base

1 stars 1 forks source link

Pin Python to 3.10 in ./devel/setup #20

Closed corneliusroemer closed 1 year ago

corneliusroemer commented 1 year ago

Specify that Python 3.10 is used in ./devel/setup as anaconda package isn't 3.11 ready.

Merging this to make CI work again, but @trs should have a look once he's back as there may be a better way.

Resolves #19

huddlej commented 1 year ago

Thank you, @corneliusroemer! I wonder if we could put this kind of config information in the recipe YAML instead like we do with Augur, for instance.

While Tom is out, @joverlee521 is the other most recent author on this repo. Do you have thoughts/preferences about which direction to use here, Jover?

corneliusroemer commented 1 year ago

@huddlej this actually isn't changing anything about the recipe. It's purely about the build system, restoring it back to way it was before things went to 3.11 and broke stuff. I'm not sure why @tsibley set things up the way he did though.

joverlee521 commented 1 year ago

Do you have thoughts/preferences about which direction to use here, Jover?

Honestly, this repo is still a bit of a black box to me. I did a little bit of exploring and tried an alternative in #22. I'm not sure what the trade-offs are so we can just wait for @tsibley to get back to review.

victorlin commented 1 year ago

22 looks good to me, but in addition to that, it's still worth considering pinning the Python version here as done in other repos. This would guard against any incompatibilities that tend to arise shortly after each new Python release (such as #19), and gives us time to decide when we want to upgrade.