search

nextstrain / conda-base

Conda package build for nextstrain-base
https://anaconda.org/Nextstrain/nextstrain-base
1 stars 1 forks source link

CI release job failing #30

Closed joverlee521 closed 1 year ago

joverlee521 commented 1 year ago

The latest CI release job is failing with the following error:

Traceback (most recent call last):
  File "/home/runner/work/conda-base/conda-base/.dev-env/bin/anaconda", line 6, in <module>
    from binstar_client.scripts.cli import main
  File "/home/runner/work/conda-base/conda-base/.dev-env/lib/python3.11/site-packages/binstar_client/__init__.py", line 26, in <module>
    from .requests_ext import NullAuth
  File "/home/runner/work/conda-base/conda-base/.dev-env/lib/python3.11/site-packages/binstar_client/requests_ext.py", line 11, in <module>
    from urllib3.filepost import choose_boundary, iter_fields
ImportError: cannot import name 'iter_fields' from 'urllib3.filepost' (/home/runner/work/conda-base/conda-base/.dev-env/lib/python3.11/site-packages/urllib3/filepost.py)

Upstream issue: https://github.com/Anaconda-Platform/anaconda-client/issues/654

joverlee521 commented 1 year ago

Most likely due to our setup job installing urllib3 v2.0.2

(Compared to our last successful run, which installed urllib3 v1.26.15)

joverlee521 commented 1 year ago

Looking into dependencies locally with conda-tree:

$ conda-tree -p /Users/jlee2346/Repos/nextstrain/conda-base/.dev-env whoneeds urllib3 -t
urllib3==2.0.2
  ├─ requests 2.31.0 [required: >=1.21.1,<3]
  │  ├─ anaconda-project 0.11.1 [required: any]
  │  │  └─ anaconda-client 1.11.2 [required: >=0.9.1]
  │  │     └─ anaconda-project 0.11.1 [required: any]
  │  │        └─ dependent packages of anaconda-project displayed above
  │  ├─ requests-toolbelt 1.0.0 [required: >=2.0.1,<3.0.0]
  │  │  └─ anaconda-client 1.11.2 [required: >=0.9.1]
  │  │     └─ dependent packages of anaconda-client displayed above
  │  ├─ anaconda-client 1.11.2 [required: >=2.20.0]
  │  │  └─ dependent packages of anaconda-client displayed above
  │  ├─ conda-build 3.24.0 [required: any]
  │  │  └─ boa 0.14.0 [required: >=3.24,<3.25]
  │  └─ conda 23.3.1 [required: >=2.20.1,<3]
  │     ├─ conda-build 3.24.0 [required: >=4.13]
  │     │  └─ dependent packages of conda-build displayed above
  │     └─ mamba 1.4.2 [required: >=4.14,<23.4]
  │        └─ boa 0.14.0 [required: >=1.0,<1.5]
  └─ anaconda-client 1.11.2 [required: >=1.26.4]
     └─ dependent packages of anaconda-client displayed above
joverlee521 commented 1 year ago

I don't see any recent changes in anaconda-client that would bump the urllib3 version, although they only require urllib3>=1.26.4 and do not guard against v2.

requests added support for urllib3 2.0 since v2.30.0 and just bumped their latest version on Anaconda to 2.31.0 yesterday.

Easiest fix for now would be to pin urllib3<2 within ./devel/setup until anaconda-client fixes things upstream.

tsibley commented 1 year ago

Sounds good to me.