search

nextstrain / conda-base

Conda package build for nextstrain-base
https://anaconda.org/Nextstrain/nextstrain-base
1 stars 1 forks source link

Exclude snakemake 7.29.0 due to bug #37

Closed corneliusroemer closed 1 year ago

corneliusroemer commented 1 year ago

See https://github.com/snakemake/snakemake/issues/2326 for bug description

This 7.29.0 bug appears to be quite impactful and we should thus exclude this version.

corneliusroemer commented 1 year ago

It's fine again with 7.30.0

corneliusroemer commented 1 year ago

I think given that the bug is fixed in 7.30 and we'll probably always pull the latest we don't need to merge this, unless we're worried someone is going to introduce a exactly a <7.30 constraint (unlikely)

victorlin commented 1 year ago

I just ran CI and it pulled version 7.30.1. We can reconsider this PR if for some reason 7.29.0 gets resolved in the future.

joverlee521 commented 1 year ago

I don't know how to tell if that's due to the change here or a constraint defined by another package

The logs of the build step in the CI run seems to point to the version requirement added in this PR.

@victorlin I've also been using conda-tree to help with debugging Conda dependency issues if you want to check it out.