search

nextstrain / conda-base

Conda package build for nextstrain-base
https://anaconda.org/Nextstrain/nextstrain-base
1 stars 1 forks source link

dev: Routinely check that the latest* package is initially installable… #42

Closed tsibley closed 12 months ago

tsibley commented 1 year ago

…to catch issues like the one in monkeypox CI¹ earlier. Since successful installation relies on external resources out of our control, we want to regularly test it to ensure we know when an external change breaks it.

* As it stands currently, this isn't strictly the latest package, just that there's some package version that's installable. To ensure the former, we'd have to query the latest version (e.g. similar to what devel/download-latest does) and pass it into setup-nextstrain-cli as an input, which would then pass it to nextstrain in NEXTSTRAIN_CONDA_BASE_PACKAGE.

Alternatively, we're likely to update nextstrain setup conda anyway to query and install the latest version itself explicitly, just like nextstrain update conda does, and so this workflow can simply wait for that change to happen.

Resolves https://github.com/nextstrain/conda-base/issues/41.

¹ e.g. https://github.com/nextstrain/monkeypox/issues/177

Checklist

tsibley commented 1 year ago

Test run: https://github.com/nextstrain/conda-base/actions/runs/6202996684

However, this as-is right now tests only that there exists some package version that's initially installable. It doesn't guarantee that package version is the latest. We could do that two ways:

  1. Query the latest version (e.g. similar to what devel/download-latest does) and pass it into setup-nextstrain-cli as an input, which would then pass it to nextstrain in NEXTSTRAIN_CONDA_BASE_PACKAGE.
  2. Update nextstrain setup conda to query the latest version and explicitly install that, just like nextstrain update conda does (c.f.).

I think (2) makes the most sense. In the meantime, testing that any version is installable is still useful, and when we update Nextstrain CLI for (2) this workflow will start always testing the latest version.

tsibley commented 1 year ago

https://github.com/nextstrain/cli/pull/312

tsibley commented 12 months ago

Updated. Test run worked. Merging.