nextstrain / dengue

Nextstrain build for dengue virus
https://nextstrain.org/dengue
8 stars 10 forks source link

Fix: update dropped strains file to list accession instead of strain names #26

Closed j23414 closed 6 months ago

j23414 commented 7 months ago

Description of proposed changes

In the phylogenetic workflow, we initially listed strains slated to be dropped from the build (due to excessive divergence or misclassification) in the config/dropped_strain.txt file, identified by their strain names. Subsequently, we transitioned to using "accession" numbers to identify strains after merging the ingest pipeline (and using ncbi-datasets api) https://github.com/nextstrain/dengue/commit/8ab810f10cc64e45a9c2baf1bf6df9d6561578bc. However, updating the corresponding dropped strain list was missed resulting in these strains not being appropriately dropped from the build.

This commit addresses this issue by adding accession numbers to ensure proper dropping of these records.

Steps to find accessions:

Related issue(s)

Checklist

Post Merge rebase and update checklist