search

nextstrain / fauna

RethinkDB database to support real-time virus analysis
GNU Affero General Public License v3.0
33 stars 13 forks source link

Include a header in titer tables #109

Closed huddlej closed 3 years ago

huddlej commented 3 years ago

Description of proposed changes

Adds a header to the titer table output based on the text fields requested from each record. This change allows users of the resulting data to easily determine what data they're looking at instead of having to guess and manually add a header each time they load these data into pandas, etc.

Although it would be nice to updated Augur's titer model code to use these headers instead of indexing titer table values by hardcoded column indices, it looks like Augur should handle the inclusion of a header column by skipping the header when its fifth column cannot be converted to a float.

Testing

Tested locally with WHO titers for HI and FRA assays.

huddlej commented 3 years ago

Nice find, @joverlee521! Since that should end up counting "strain" once, I'll merge this, but we can keep our eyes out for other regressions.