nextstrain / fauna

RethinkDB database to support real-time virus analysis
GNU Affero General Public License v3.0
33 stars 13 forks source link

Use custom runtime #170

Open victorlin opened 20 hours ago

victorlin commented 20 hours ago

follow-up to https://github.com/nextstrain/fauna/issues/169#issuecomment-2492503576

Context

Fauna is currently available through the Nextstrain managed runtimes (docker-base, conda-base). There are a couple of reasons to consider its removal from those:

  1. It is only used for seasonal-flu and avian-flu and there are no plans to incorporate new pathogens during the expansion of Nextstrain's core pathogens.
  2. With the current usage, there is no reason to update the code and dependency version constraints. This goes against the grain of the base runtimes, which are frequently kept up to date with latest versions of tools and their dependencies. At some point down the road, dependencies may fail to resolve entirely (e.g. if Fauna is pinned to Pandas v1 and Augur stops supporting that version).

Possible solutions

  1. Define, publish, and use a custom Docker image that extends nextstrain/base.
  2. Define and use a custom Conda environment that extends nextstrain::nextstrain-base.

Both of these could be pursued to allow flexibility for users.

victorlin commented 18 hours ago

This should be considered under a broader proposal: https://github.com/nextstrain/public/issues/7

joverlee521 commented 1 hour ago

Fauna is not included in the Nextstrain conda runtime (past discussion on this in https://github.com/nextstrain/conda-base/issues/3), which is even more reason to just use a custom Docker image for fauna.