Closed sidneymbell closed 7 years ago
The dengue scripts are good, but some things need changing before this can be merged:
source-data/geo_synonyms.tsv
vdb/denv_upload.py
vdb/dengue_upload.py
vdb/parse.py
source-data/geo_regions.tsv
source-data/denv_strain_name_fix.tsv
source-data/dengue_strain_name_fix.tsv
The easiest thing will be probably be to start a new branch (say dengue or dengue_merge) from master and rebase clean changes on top of this new branch.
dengue
dengue_merge
master
The dengue scripts are good, but some things need changing before this can be merged:
source-data/geo_synonyms.tsv
has had its formatting messed up with spaces converted to tabs: https://github.com/nextstrain/fauna/pull/40/files#diff-8611720e569f2560f622006c368b7214R11vdb/denv_upload.py
should bevdb/dengue_upload.py
for consistencyvdb/parse.py
should be unstaged. I know these are fixes, but better to have more atomic pull requestssource-data/geo_regions.tsv
should keep the sorting by region (2nd column) like it is currentlysource-data/denv_strain_name_fix.tsv
should besource-data/dengue_strain_name_fix.tsv
for consistency