Closed trvrb closed 6 years ago
I've made this change to vdb/flu
. I'm going to leave this issue open until vdb/zika
, etc... is migrated.
I've decided to further collapse regions to:
I'll update fauna and vdb/flu
now. This should improve flu / dengue / mumps, etc... geo inferences and untangle the global map. This is the original nextflu region map.
This has become an issue for auspice, as well. While it needs to be sanity checked in auspice, it ideally shouldn't be cropping up in the data at all / should be fixed on the backend before it ever hits the front end. Details cross-posted from https://github.com/nextstrain/auspice/pull/330 (is there a better way to manage this?)
Re:
The ebola dataset is not animating, with the Bezier error occurring when I press play (stack trace printed in previous comment)
Just confirmed this is a dataset-specific bug. It's the same problem that was previously in the dengue build. I suspect this is due to the recent changes to geo metadata definitions in fauna.
I.e., this happens when two locations have a distance between them of 0
, but it still tries to draw a transmission because they have different geo metadata attached to them. For example, Ebola is failing when it tries to draw the transmission between these two points:
This then causes the value for end
passed to Bezier
here to be -Infinity
because the denominator is 0
.
This was the same bug that was previously messing with dengue. Fixed with a dataset rebuild, but this is a bandaid.
This is resolved now.
Current geo regions are specified here:
https://github.com/nextstrain/fauna/blob/master/source-data/geo_regions.tsv
There are 14 of them:
The current proposal is to collapse to 12 regions:
Any other suggestions?