search

nextstrain / fauna

RethinkDB database to support real-time virus analysis
GNU Affero General Public License v3.0
33 stars 13 forks source link

argument parser in upload.py #83

Open rneher opened 6 years ago

rneher commented 6 years ago

the parser is currently instantiated in vdb/upload.py. repeated imports from upload will, therefore, use the exact same parser and addition of arguments in other files generate argument clashes. code following this line

https://github.com/nextstrain/fauna/blob/master/vdb/upload.py#L9

should be wrapped into a function get_parser() or similar.

4rund3v commented 4 years ago

I think i can work on this , if this is still relavent.

jstoja commented 4 years ago

I don't think this is relevant anymore as it is described since it has been wrapped already. Although, reading through vdb/download.py, It seems that it's doing a lot of parsing of the arguments. This probably could be extracted to a vdb/parser.py.

tjGhani commented 4 years ago

@rneher @trvrb I believe this issue can be closed since the issue seems resolved and the parser is wrapped in a function, as originally suggested.