nextstrain / forecasts-ncov

SARS-CoV-2 variant growth rates and frequency forecasts
https://nextstrain.org/sars-cov-2/forecasts/
7 stars 2 forks source link

Counts update doesn't invalidate CloudFront #32

Closed trvrb closed 1 year ago

trvrb commented 1 year ago

Current Behavior

When update-ncov-gisaid-clade-counts.yaml or update-ncov-open-clade-counts.yaml are run, they run:

S3_DST=s3://nextstrain-data/files/workflows/forecasts-ncov/gisaid
./ingest/bin/upload-to-s3 global_clade_counts.tsv "$S3_DST"/nextstrain_clades/global.tsv.gz

to push updated counts file to S3 bucket nextstrain-data. However, despite the existence of cloudfront-invalidate script, I'm pretty sure the invalidation is not called as part of the GitHub Action workflow.

I discovered this today when I was trying to update the forecasts to include clade 23B. This was in the available metadata, but just running the GitHub Action (or walking through the commands called by the GitHub Action), resulted in a push to S3, but not an invalidation. I just fixed today's issue with a manual invalidation from the AWS Console.

Expected behavior

When files are pushed to the S3 bucket nextstrain-data, these files should be invalidated on the CloudFront domain fronting data.nextstrain.org.