nextstrain / forecasts-ncov

SARS-CoV-2 variant growth rates and frequency forecasts
https://nextstrain.org/sars-cov-2/forecasts/
7 stars 2 forks source link

Add clade definitions for 24A and 24B #94

Closed joverlee521 closed 6 months ago

joverlee521 commented 6 months ago

Description of proposed changes

Add new Nextstrain clades 24A and 24B, following up on https://github.com/nextstrain/ncov/pull/1103. See commits for details.

Checklist

joverlee521 commented 6 months ago

Ah, right the test run completed successfully but the trial results does not include 24A/24B because they are not in the clade counts yet.

Will have to wait on the release of the new Nextclade dataset and full re-run of ncov-ingest to see these new clades come through.

corneliusroemer commented 6 months ago

There should be just a few new clade calls (not yet all as I forgot full run), enough to test, so I triggered test runs again. https://github.com/nextstrain/forecasts-ncov/actions/runs/8705257996

It's probably worth merging asap as the lack of new clades causes some issues, see Canada for example

image
corneliusroemer commented 6 months ago

Coloring works - we're just waiting for the updated data

image
joverlee521 commented 6 months ago

Force-pushed to include changes to the viz app to update the pivot clade.

Merging now since today's ncov-ingest run will be a full re-run to include the new Nextstrain clades (Slack).