nextstrain / measles

Nextstrain build for measles virus
https://nextstrain.org/measles
0 stars 6 forks source link

[do not merge] add cores flag #6

Closed j23414 closed 1 year ago

j23414 commented 1 year ago

Description of proposed changes

Update documentation since newer version of snakemake requires --cores, matches the zika repo

j23414 commented 1 year ago

I see, nextstrain-cli is auto adding --cores=all

j23414 commented 1 year ago

In that case, @tsibley is it okay to submit PRs to remove --cores all flags from nextstrain build . statements in our documentation for consistency?

@joverlee521 mentioned a good point that some people may be using an earlier version of nextstrain-cli (which would require --cores all). Then @corneliusroemer also brought up a good point that if they are using an earlier version of nextstrain that there will be an error msg telling them to add the --cores all flag back in. Ergo easy to debug for both.

tsibley commented 1 year ago

@j23414 Yep, I'm supportive of removing --cores all from our documented nextstrain build invocations.