search

nextstrain / mpox

Nextstrain build for mpox virus
https://nextstrain.org/mpox
MIT License
42 stars 19 forks source link

Add pre-commit to CI lint action #195

Closed corneliusroemer closed 1 year ago

corneliusroemer commented 1 year ago

CI errors with

[Error: .github#L1](https://github.com/nextstrain/monkeypox/commit/8d0c898f30d9e6f99ae682edb5b544763af2bbbd#annotation_14383331521)
pre-commit/action@v3.0.0 is not allowed to be used in nextstrain/monkeypox. Actions in this workflow must be: within a repository owned by nextstrain, created by GitHub, or matching the following: aws-actions/configure-aws-credentials@*, codecov/codecov-action@*, conda-incubator/setup-miniconda@*, docker/build-push-action@*, docker/login-action@*, docker/setup-buildx-action@*, mamba-org/provision-with-micromamba@*, peter-evans/create-pull-request@v3, stefanzweifel/git-auto-commit-action@v4, docker/setup-qemu-action@*, dependabot/fetch-metadata@*, mamba-org/setup-micromamba@*, ruby/setup-ruby@v1.

Do you think it's worth adding precommit to the list of approved actions @victorlin?

corneliusroemer commented 1 year ago

Scrap that, pre-commit.ci is much better, the action is deprecated anyways

Amazing how fast that ci is: https://results.pre-commit.ci/run/github/493877605/1695563576.CIqEySbARgqv9iZywkGRAA

Using it in #200