search

nextstrain / mpox

Nextstrain build for mpox virus
https://nextstrain.org/mpox
MIT License
39 stars 16 forks source link

Fix ingest uploads #223

Closed joverlee521 closed 7 months ago

joverlee521 commented 7 months ago

Fix bug that was introduced in https://github.com/nextstrain/mpox/pull/222

The testing done on branch runs do not include the Slack notifications, so this bug was not revealed in the test run. I only noticed the workflow as failing because our internal #monkeypox-updates channel had been quiet for over a week.

This did not trigger our usual error notifications in Slack because the error occurs during the DAG building process before the start of the actual workflow run.

Checklist

corneliusroemer commented 7 months ago

Thanks for spotting! Was about to investigate myself. Should we include Slack notifications to a test channel for better test coverage? Wouldn't be hard to set up a test slack channel so this type of bug is spotted more quickly next time round.

joverlee521 commented 7 months ago

Should we include Slack notifications to a test channel for better test coverage? Wouldn't be hard to set up a test slack channel so this type of bug is spotted more quickly next time round.

Yup, see https://github.com/nextstrain/mpox/pull/224