search

nextstrain / nextstrain.org

The Nextstrain website
https://nextstrain.org
GNU Affero General Public License v3.0
87 stars 49 forks source link

Move manifest.json files into source code #678

Closed jameshadfield closed 1 year ago

jameshadfield commented 1 year ago

The manifest files are a continual point of confusion, and part of the reason may be their location on S3. Bringing them into source code has benefits for visibility/understanding, ease of tracking changes, and should help with their eventual removal.

Historically, these were part of Auspice's source code and were extracted into their own files in order to allow other groups to more easily use Auspice. As nextstrain.org is not intended for external use there is no problem bringing them back into source code.

Manifests taken 2023-04-17 at ~11h00 (NZ time) using

curl --compressed "https://nextstrain-data.s3.amazonaws.com/manifest_guest.json" --output data/manifest_core.json
curl --compressed "https://nextstrain-staging.s3.amazonaws.com/manifest_guest.json" --output data/manifest_staging.json

(I'll separate out the first commit as it's own PR if this PR isn't merged for some reason.)

trvrb commented 1 year ago

The ability to have Heroku review apps to test changes here seems very valuable. Currently, the necessity to edit live file places a scary bar on modifying manifest.