GitHub Actions deploy job succeeds even when Heroku build fails

[tsibley]

Consider this GitHub Actions deploy job from the morning. It kicked off this build on Heroku. That build failed, as you can see in Heroku logs and also the GitHub job logs, but the GitHub job's conclusion was success.

It should check the build status after the build completes (successfully or not) and assert success.

[tsibley]

I'm re-running the deploy job in that workflow to see if this was transient or not...

[tsibley]

That worked, so the errors themselves were transient (or at least don't occur consistently).

That said, that's still separate from this issue: making sure our CI deploy status reflects Heroku accurately.