nextstrain / nextstrain.org

The Nextstrain website
https://nextstrain.org
GNU Affero General Public License v3.0
87 stars 49 forks source link

dev: Check the Heroku build status during our GitHub Actions deploy job #727

Closed tsibley closed 9 months ago

tsibley commented 9 months ago

We'd been assuming builds on Heroku were always successful, which meant the GitHub Actions status could (and did) mask build issues on Heroku.

Resolves https://github.com/nextstrain/nextstrain.org/issues/726.

Checklist

tsibley commented 9 months ago

Worked in the success condition: https://github.com/nextstrain/nextstrain.org/actions/runs/6486469947/job/17614896676#step:6:1

We'll see I guess in the future if it works in the failure condition. I don't think we need to intentionally fail a deploy to test it (but we could).