search

nextstrain / nextstrain.org

The Nextstrain website
https://nextstrain.org
GNU Affero General Public License v3.0
87 stars 49 forks source link

[bugfix] default params for signedUrl() #749

Closed jameshadfield closed 6 months ago

jameshadfield commented 8 months ago

The default parameter values for this function would only be used in the case where no argument was provided, which makes no sense as a bucket and key will always be needed. These changes preserve the intended defaults of headers={} and method='GET'. (Reading the previous code it seems the intention was to allow a default method of 'GET', despite the docstring indicating it was required.)

jameshadfield commented 6 months ago

Updated to use the requested syntax, rebased onto master and tested locally. Will merge once CI passes.