search

nextstrain / nextstrain.org

The Nextstrain website
https://nextstrain.org
GNU Affero General Public License v3.0
87 stars 49 forks source link

[CI] False positive build failures #794

Closed jameshadfield closed 4 months ago

jameshadfield commented 4 months ago

Our CI monitors & reports the status of heroku builds for pushes to master. Today's CI (triggered by the merge of #791) reported a build failure, however the build succeeded (heroku build log).

The CI observed "status": "pending" which is not "succeeded" and thus the CI failed. I guess (?) this is caused by curl command returning before the build was actually finished. I haven't investigated further.

tsibley commented 4 months ago

Yeah, I saw this the other day too. I think we're racing Heroku's API here and inserting a short delay should probably make it Just Work again.

(That said, I do still want to revise the deploy process so it's less slow which in many incarnations would render this race non-existent.)