search

nextstrain / nextstrain.org

The Nextstrain website
https://nextstrain.org
GNU Affero General Public License v3.0
88 stars 49 forks source link

endpoints/cli: Support PEP 440/508 version range constraints for downloads #797

Closed tsibley closed 7 months ago

tsibley commented 7 months ago

This allows URLs like:

https://nextstrain.org/cli/download/>=7.4.0/standalone-x86_64-unknown-linux-gnu.tar.gz

which will let us use the standalone installer, e.g.

curl -fsSL --proto '=https' https://nextstrain.org/cli/installer/linux | bash -s '>=7.4.0'

in automated contexts where we want to be able to declare constraints like lower version bounds or incompatible versions.

Note that the standalone installer on macOS on aarch64 hardware does very rudimentary version comparison¹ to decide if the requested version is older or newer than the first release with actual aarch64 support (8.2.0), and it won't compare version range constraints correctly: they'll always be considered greater than (newer/later) than 8.2.0. But I expect this to be fine in practice and not matter for actual usage.

We depend on an older version of @renovatebot/pep440 (<3) because >=3 adds a dependency on Node >=18 and this codebase is still on Node 16. I reviewed the changelog for newer versions of the package and nothing else substantial seems to have changed anyhow.

Related-to: https://github.com/nextstrain/.github/pull/55

¹ https://github.com/nextstrain/cli/pull/358 https://github.com/nextstrain/cli/blob/af976b06/bin/standalone-installer-unix#L146-L154

Checklist

tsibley commented 7 months ago

I'm going to merge this pre-review so I get a little chance to see how it works in production in practice. It'll also unblock https://github.com/nextstrain/.github/pull/55.

I definitely still welcome post-merge review! :pray: