search

nextstrain / nextstrain.org

The Nextstrain website
https://nextstrain.org
GNU Affero General Public License v3.0
87 stars 49 forks source link

Unversioned resource listings are truncated #896

Closed victorlin closed 3 weeks ago

victorlin commented 3 weeks ago

Current Behavior

When setting versioned=false on ListResources, the resources entries are truncated.

image

Expected behavior

Resource entries should not be truncated.

image

How to reproduce

  1. Go to https://next.nextstrain.org/staging
  2. Observe bug

Scope

This was introduced in 54be4d60c17e62d236ad95d10aff3895ca0a4553.

This affects /staging but not /pathogens. It may also affect work on #870 that uses unversioned resources.

Possible solution

Fix the condition here to not return w on lack of updateCadence:

https://github.com/nextstrain/nextstrain.org/blob/2e4844e6472ef4c1cf3aebf366fd6901758f64c1/static-site/src/components/ListResources/IndividualResource.tsx#L22-L34

jameshadfield commented 3 weeks ago

This doesn't affect /pathogens which is the only place where this component is used (as of now). It may affect work on https://github.com/nextstrain/nextstrain.org/issues/870 that uses unversioned resources.

the :bug: is visible on https://next.nextstrain.org/staging

victorlin commented 3 weeks ago

@jameshadfield oh I didn't realize ListResources was being used on staging with versioned=false, thanks!