nextstrain / nextstrain.org

The Nextstrain website

https://nextstrain.org

GNU Affero General Public License v3.0

87 stars 49 forks source link

Use showcase on splash #901

Closed victorlin closed 2 weeks ago

victorlin commented 3 weeks ago

preview

![image](https://github.com/nextstrain/nextstrain.org/assets/13424970/5f54de1f-bcee-477f-91cd-51ad18fdaf97)

Description of proposed changes

Moving cards from individual sections to a shared showcase defined by a single YAML file.

For later

surface more info for each card (ref)

Related issue(s)

849

Checklist

[x] Decide on contents: 64496766d88a30588d9f74b6228587091109810c...9f72478d1931cd8e60961a93b0758453ab242e37
[x] Checks pass
[x] ~Check if changes affect the resource index JSON revision~
[x] Post-merge: PR to fix styles: #916
[x] Post-merge: issue for typography consistency: #917

trvrb commented 2 weeks ago

I updated tiles further mainly to include more examples and to simplify text. I also did a small update to the styling to make text fit better. Here's before 4bc2acc4afd80eac59ea21610a79556164044750:

before

And here's after:

updated

trvrb commented 2 weeks ago

Nice work here @victorlin! With the small tweaks above, I'm happy for this to be merged into master. I like the staging here where revamp of the linkouts can be done in a subsequent PR ala https://github.com/nextstrain/nextstrain.org/pull/902.

victorlin commented 2 weeks ago

Thanks for pushing the tweaks @trvrb. I've replaced 4bc2acc4afd80eac59ea21610a79556164044750 with 9f72478d1931cd8e60961a93b0758453ab242e37...52e964e8da66d8865f279758c3b85329ef9aa704 so that the styling adjustments don't affect the cards on /groups.

victorlin commented 2 weeks ago

I'll plan to merge this tomorrow, leaving another day for reviews.

In terms of implementation, I'm confident in most changes except 1414985c may prompt some feedback. After some thinking in https://github.com/nextstrain/nextstrain.org/issues/849#issuecomment-2161839537 and some design drafting today, I've a sense that we'll eventually want enough deviation where it doesn't make sense to re-use the same Showcase component between splash and /pathogens. But this is still the easiest approach at the moment, and the preview looks good.