nextstrain / nextstrain.org

The Nextstrain website
https://nextstrain.org
GNU Affero General Public License v3.0
89 stars 48 forks source link

Add splash tile / pathogen showcase entry for `seasonal-cov` #940

Closed genehack closed 1 month ago

genehack commented 5 months ago

Context

Suggested by @jameshadfield during review of #939

Creating a new issue for this because I'm not sure if the intent of the showcase is for there to be a tile for everything or just for "notable" datasets. If the latter, I'm not sure seasonal-cov qualifies?

To be clear, I think we're talking about a tile in the showcase on https://nextstrain.org/pathogens, not the top-level splash page.

Opinions sought!

joverlee521 commented 5 months ago

Should we showcase any pathogen that is being automatically updated? I'd hope any pathogen that we think is important enough automate is also "notable"

victorlin commented 5 months ago

I believe the original list added in f57bf94a257127f0bc1d9ea8fdc6d4af7fff3b02 was short because the showcase was not expandable and thus implicitly capped at 9 entries at max width of .container. Now that it's expandable, I would propose adding at the very least any automatically updated pathogen, if not all available pathogens and repurposing it as more like a "table of contents".

victorlin commented 2 months ago

For splash page tiles defined by featured-analyses.yaml, my understanding is that @trvrb is maintaining this so I would run any new entries through him to determine if/where to place the tile relative to existing tiles.

victorlin commented 2 months ago

Now that it's expandable, I would propose adding at the very least any automatically updated pathogen, if not all available pathogens and repurposing it as more like a "table of contents".

If adding every available pathogen, I would also propose alphabetical sorting to align with how we are now sorting groups. The current sorting is something along the lines of [some "popular" items] + [other items based on time of addition] which is pretty arbitrary.

trvrb commented 2 months ago

If the showcase gets too long, it no longer serves the purpose to highlight new / notable pages. I wouldn't have every automatically updated pathogen (this is what /pathogens is for). I'd also be rotating out previous highlights pretty judiciously. That said, I think the current splash page could handle up 18 cards maximum (3 rows of 6). So we don't have to rotate out quite yet. The top 4-6 should have lots of thought as they're above the fold (as many users won't click the carat).

In this particular case, I think rotating in seasonal CoV near the bottom would be fine, but it would rotate out sooner than most.

If adding every available pathogen, I would also propose alphabetical sorting to align with how we are now sorting groups.

It's important that pathogens of current scientific / public health focus stay at the top of the list. It will need to be manually tended to.

victorlin commented 2 months ago

There are two separate "showcases" being conflated here:

  1. "Featured analyses" on https://nextstrain.org/ image

  2. "Showcase resources" on https://nextstrain.org/pathogens image

Everything said above in https://github.com/nextstrain/nextstrain.org/issues/940#issuecomment-2351941145 I agree is applicable to (1). I am proposing adding every pathogen and sorting alphabetically to (2). I think this issue is mostly about (2):

To be clear, I think we're talking about a tile in the showcase on https://nextstrain.org/pathogens, not the top-level splash page.

trvrb commented 2 months ago

Ah! Sorry, this was my failure at reading comprehension. Yes, I agree that the best thing for nextstrain.org/pathogens is to include a tile for every pathogen. It feels a little weird to me that if sorting alphabetically, we'll lose SARS-CoV-2 from the "above-the-line" row of tiles that's a single click away. But, I think this is okay as the splash page showcase should maintain SARS-CoV-2 front and center. /pathogens can be more of an encyclopedia in this case and so yes I think alphabetical makes sense.

victorlin commented 1 month ago

Done in 2103297425e8e23d8ddfcadce3b235c6a012abdf

trvrb commented 1 month ago

Awesome!