Job AWS console link broken

[jameshadfield]

Current Behavior

The URL behind the "AWS Batch Console" link in the run-build summary (e.g.) is broken as it contains region=***. This is probably a misconfiguration in how we're using the pathogen-repo-build workflow.

I can fix this next week, just noting it here.

[tsibley]

That looks like AWS_REGION is being passed as a secret, so its value is being masked in the logs by GitHub Actions.

[tsibley]

(This is a reason not to use secrets for non-secret things if you can help it.)

[joverlee521]

Ah, I forgot to remove the AWS_DEFAULT_REGION secret after I removed references to it in the GH Action workflows.

I've deleted the secret from this repo. If we need to set the value for any reason in the future, we should use the non-secret GH Action variables.

[jameshadfield]

Thanks for fixing Jover. For anyone else who wants to understand why this happened:

• The reusable action hardcodes "region=us-east-1" in the URL. The action never uses AWS_DEFAULT_REGION.
• The RSV repo had a repo-level secret AWS_DEFAULT_REGION="us-east-1"
• GitHub will automagically "mask any secrets that might have been added accidentally" to the GITHUB_STEP_SUMMARY