search

nextstrain / sphinx-theme

A Sphinx theme for Nextstrain's documentation, based on Read The Docs' default theme.
https://docs.nextstrain.org/projects/sphinx-theme/
MIT License
0 stars 5 forks source link

Tidy the footer #10

Closed tsibley closed 3 years ago

tsibley commented 3 years ago

A bunch of small corrections and minor tidying in the footer. See commit messages for details.

Tested locally by building docs.nextstrain.org with this branch with:

env PYTHONPATH=$HOME/nextstrain/sphinx-theme/lib/ make html
tsibley commented 3 years ago

Using the RTD previews, you can also compare the footers before and after.

tsibley commented 3 years ago

E.g. myself and Moira and Cassia (and perhaps others) are not included in the "Nextstrain is built by" gallery of pictures/names.

Oh! Well let's fix that too then!

tsibley commented 3 years ago

@eharkins Look better now?

eharkins commented 3 years ago

@eharkins Look better now?

Looks great, thanks! I wonder how we can continue to keep the footer on nextstrain.org (and any other potential instances of this footer) in sync with the docs footer / vice versa, in terms of both the list of team members and the html/css code. Assuming the code lives here, maybe there's a nice way to install the theme in nextstrain.org and import it there?

tsibley commented 3 years ago

In terms of keeping it in sync, I don't think there's a particularly nice technical solution. Easier and simpler to just keep doing it manually. We can make a checklist in comments of the places we maintain this footer, so that anyone updating one place can port their changes to the others too.