search

nextstrain / zika

Nextstrain build for Zika virus
https://nextstrain.org/zika
8 stars 10 forks source link

phylogenetic: Use inline root sequence #57

Closed joverlee521 closed 2 months ago

joverlee521 commented 2 months ago

Based on feedback from @jameshadfield in https://github.com/nextstrain/zika/pull/56#issuecomment-2058060422

Looking at the existing dataset files on S3, the 5 KiB root-sequence.json is pretty negligible when the main Auspice JSON is only 163 KiB. Nextstrain datasets are limited by the 500MB memory cap in Chrome,¹ so we'd be fine adding the root sequence inline.

¹ https://github.com/nextstrain/auspice/issues/1622

Checklist

joverlee521 commented 2 months ago

Merging since the CI run's outputs include root_sequence in the Auspice JSON and the dataset looks good in auspice.us

joverlee521 commented 2 months ago

Manually deleted cache and triggered a re-run of the ingest-to-phylo workflow.

Once complete