search

nextstrain / zika

Nextstrain build for Zika virus
https://nextstrain.org/zika
8 stars 10 forks source link

Rename phylogenetic CI config file to standard name #63

Closed genehack closed 1 month ago

j23414 commented 1 month ago

Minor remark, I would add a link to the version of the pathogen-repo-guide (what standard you are conforming to) in your commit message:

For example:

Rename phylogenetic CI config file to standard name

Conforms to https://github.com/nextstrain/pathogen-repo-guide/blob/80cc1733b47f173772fe45005b82a69c6f8cb6c9/phylogenetic/defaults/config.yaml
genehack commented 1 month ago

Minor remark, I would add a link to the version of the pathogen-repo-guide (what standard you are conforming to) in your commit message:

For example:

Rename phylogenetic CI config file to standard name

Conforms to https://github.com/nextstrain/pathogen-repo-guide/blob/80cc1733b47f173772fe45005b82a69c6f8cb6c9/phylogenetic/defaults/config.yaml

I'm gonna die on the hill that using links to specific SHAs is an anti-pattern.

If we want to refer to stable versions of something, there should be a version tag applied to a SHA.

j23414 commented 1 month ago

I'm gonna die on the hill that using links to specific SHAs is an anti-pattern.

Haha, I won't die on this hill so feel free to leave out the link.

I've gotten used to adding a SHA pattern so if I get questions about why my commits don't match the pathogen-repo-guide (or X repo), I have more evidence than "I was matching an earlier version, but can't point to it".