nextui-org / nextui-cli

⌨️ A CLI tool that unlocks seamless NextUI integration.
MIT License
37 stars 14 forks source link

feat: pre-catch error for package manager #39

Closed withden closed 4 months ago

withden commented 4 months ago

📝 Description

This PR request will pre-catch errors for future package managers, which might affect UX.

✅ Type of change

winchesHe commented 4 months ago

@withden Hi, i think it will better to make catch in getPackageManagerInfo funciotn, then anywhere using getPackageManagerInfo will include this catch

like

if (!packageManagerInfo) {
        Logger.prefix(
          'error',
          `${packageManager} (package manager) is not supported yet. Please report it as a feature request`
        );

        process.exit(1);
      }
withden commented 4 months ago

@winchesHe I done

Thanks for reviewing and feedback

winchesHe commented 4 months ago

@withden Hi, thx your enhance PR, but as we think this condition not useful for now, cause current official NextUI support package mannager is fours: npm, yarn, pnpm, bun. If there are new suppport there will update as well, so this judge may not useful now, btw thx your contribute, I will temporary close this PR ❤️