refactor: add imports recommended in node

sebastiandottop commented 4 months ago

📝 Description

Hi team nextui,

In this pr I took the trosxuble to refactor the node module imports according to today's recommended imports

thanks for reading

✅ Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Refactoring (improve a current implementation without adding a new feature or fixing a bug)
[ ] Improvement (non-breaking change which improves an existing feature)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

winchesHe commented 4 months ago

@castrogarciajs Hi, could you explain what different between two import methods

sebastiandottop commented 4 months ago

Hi @winchesHe, yes of course,

Since nodejs version 16 it is no longer recommended to call native modules by name

Example (Not recommended)

import path from 'path'

It is recommended to use the node: prefix and it reduces the risk of a module present in node_modules overriding the newer imports.

It is also a more explicit protocol makes it more readable and also makes it clear that you are importing a built-in module. As there are many built-in modules, this extra information is useful for beginners or for someone who does not know some of them.

Resource where I learned what was explained: https://github.com/nodejs/node/issues/38343

Example (Recommended)

import path from 'node:path'

winchesHe commented 4 months ago

I got thx~ @castrogarciajs

nextui-org / nextui-cli