nextui-org / nextui

🚀 Beautiful, fast and modern React UI library.
https://nextui.org
MIT License
21.96k stars 1.54k forks source link

[BUG] - Button Group issues #1626

Closed niklasp closed 1 year ago

niklasp commented 1 year ago

NextUI Version

2.0.15

Describe the bug

variant="bordered" does not show correct borders, the selected tab should have all borders

Bildschirmfoto 2023-09-14 um 21 40 21

Also setting radius on the ButtonGroup does not affect the buttons

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

Create a button group with buttons, try to set radius or use bordered variant

Expected behavior

see above

Screenshots or Videos

No response

Operating System Version

mac0s

Browser

Firefox

niklasp commented 1 year ago

is this also fixed: Also setting radius on the ButtonGroup does not affect the buttons

dar0xt commented 1 year ago

same for me

but it works for me.

  <div className="flex flex-row">
      <NextUiButton b className={`rounded-r-none ${className}`} {...rest} />
      <Dropdown placement="bottom-end">
        <DropdownTrigger>
          <Button isIconOnly className="rounded-l-none">
            <MdExpandMore />
          </Button>
        </DropdownTrigger>
        <DropdownMenu
          disallowEmptySelection
          aria-label="Merge options"
          selectedKeys={selectedOption}
          selectionMode="single"
          onSelectionChange={(selection) => {
            setSelectedOption(selection as Set<string>)
          }}
          className="max-w-[300px]"
        >
          <DropdownItem key="merge" description={descriptionsMap['merge']}>
            {labelsMap['merge']}
          </DropdownItem>
          <DropdownItem key="squash" description={descriptionsMap['squash']}>
            {labelsMap['squash']}
          </DropdownItem>
          <DropdownItem key="rebase" description={descriptionsMap['rebase']}>
            {labelsMap['rebase']}
          </DropdownItem>
        </DropdownMenu>
      </Dropdown>
    </div>