nextui-org / nextui

🚀 Beautiful, fast and modern React UI library.
https://nextui.org
MIT License
21.48k stars 1.4k forks source link

[BUG] - `hideThumbs` prop hides both thumbs and `marks` on Slider component #2880

Closed hhaste closed 4 months ago

hhaste commented 4 months ago

NextUI Version

2.3.6

Describe the bug

Passing the hideThumbs prop on the Slider component also hides the labels of any marks.

Your Example Website or App

https://stackblitz.com/edit/nextui-slider-hidethumbs?file=app%2Fpage.tsx

Steps to Reproduce the Bug or Issue

  1. Open the example website
  2. Go to line 9 of app/page.tsx
  3. Pass the hideThumbs prop

Expected behavior

When passing the hideThumbs prop to the Slider component, I expected only the slider thumbs to be hidden, but I am noticing that it also hides any marks that I passed.

Screenshots or Videos

https://github.com/nextui-org/nextui/assets/46465883/a82c84a1-e823-4837-a988-63d4f8d21416

Operating System Version

Windows

Browser

Chrome

linear[bot] commented 4 months ago

ENG-741 [BUG] - `hideThumbs` prop hides both thumbs and `marks` on Slider component