Fix types - Githubissues

nextui-org / tailwind-variants

🦄 Tailwindcss first-class variant API

https://tailwind-variants.org

MIT License

2.42k stars 70 forks source link

Fix types #41

Closed mskelton closed 1 year ago

mskelton commented 1 year ago

Description

Quite a bit going on in this PR, but broken down there are two main goals.

Disable skipLibCheck as that also disables checking d.ts files in this repo. This would have caught the circular type reference issue in https://github.com/nextui-org/tailwind-variants/pull/39.
Fix all existing type errors in the d.ts files.

Fixes #33

Additional context

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Follow the Style Guide.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

mskelton commented 1 year ago

@jrgarciadev Have you had a chance to review this PR?

jrgarciadev commented 1 year ago

@jrgarciadev Have you had a chance to review this PR?

Hi @mskelton sorry I haven't had the chance to review it in deep, I hope to review it soon 🙏🏻