fix: align class value with tailwind-merge

marbemac commented 1 year ago

Description

This PR aligns the ClassValue type with with corresponding type from tailwind-merge. In particular, the old type was missing 0 and false as possible values. This makes it difficult to use tailwind-merge + tailwind-variants together since the base class typing is different between the two projects.

What is the purpose of this pull request?

[x] Bug fix (kind of?)
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Follow the Style Guide.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

marbemac commented 1 year ago

Hi @mskelton - any chance ya'll are thinking about cutting a release soon? Thanks!

mskelton commented 1 year ago

@marbemac I don't have publish permissions, going to defer to @jrgarciadev for that request.

marbemac commented 1 year ago

@jrgarciadev sorry to bother again, but any chance ya'll could cut a release 🙏?

jrgarciadev commented 1 year ago

Hey @marbemac yes for sure I plan to release tailwind-variants new version as soon as we end testing it on NextUI, by the end of this week

marbemac commented 1 year ago

🎉 thank you!

nextui-org / tailwind-variants