Open rfriberg opened 6 years ago
This is an awesome idea. I am bit biased to passing this options to maps. It would be better not to have too many globals going on? If we are going to set this option up, we probably have to offer a way to change the language on the map too.
( one thing that comes up to my mind now: if we update the language of Tangram, it would reflect it right away, but others (routing machine and geocoder) would hold the changes until they get something to execute. 🤔 )
I'm leaning towards # 2, as well (set up attribute on MapControl
rather than on L.Mapzen
).
I'm going to bump this up to a more near-term milestone because "We Can Do It!" 💪
Goal: mapzen.js should make it easy for users to set a default language for all components.
Mapzen Basemaps, Search (geocoder), and Turn-by-turn (routing) all individually allow for language localization. However, these parameters are somewhat buried and not shared across components.
For example, to change the basemap, search, and routing directions to German, you must set a parameter in three different places:
There are a few ways we could make this easier for the user:
Set up a global variable on L.Mapzen (e.g.,
L.Mapzen.language
) to be used by all components (similar to how we handle api keys)Set up an attribute on the
MapControl
object and pass to all componentsImprove documentation for changing the default language on all three components
Other things to consider:
@hanbyul-here thoughts?