search

nexus-xyz / nexus-zkvm

The Nexus zkVM: The zero-knowledge virtual machine
https://docs.nexus.xyz
Apache License 2.0
756 stars 242 forks source link

Add Nova Public Parameter benchmark for SDK #267

Closed duc-nx closed 3 months ago

duc-nx commented 3 months ago

Summary:

Test Plan:

Stack created with Sapling. Best reviewed with ReviewStack.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nexus-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 6:00pm
duc-nx commented 3 months ago

I had a hard time moving from sdk to nova-benches, mainly because of the type PP is defined in sdk. I would need to duplicate the PP type and trait in nova-benches similar to sdk, this is redundant work. Can I let the benchmark run under sdk?

sjudson commented 3 months ago

You don't need to use the PP type from sdk, you can use the nova specific parameter types (as is used, e.g., in nova-benches/ at present: https://github.com/nexus-xyz/nexus-zkvm/blob/main/nova-benches/benches/nova.rs#L20).

duc-nx commented 3 months ago

moved to nova-benches/ in b7d1403