nexus-xyz / nexus-zkvm

The Nexus zkVM: The zero-knowledge virtual machine
https://docs.nexus.xyz
Apache License 2.0
756 stars 242 forks source link

Add Github Action cache to improve CI time #269

Closed duc-nx closed 3 months ago

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nexus-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 7:06pm
duc-nx commented 3 months ago

Hmm, I didn't know we have build cache, perhaps because I only look at build time in CI. When I made this PR, I notice the build time improve. For example: the test-smoke and test-sdk usually take 8 to 10 minutes, now down to 5 to 7 minutes.

I separate the clippy, because this way we have code scanning features and can be viewed overtime in Github settings. Other than that, I group a few build and check together, so they don't have to query the cache if they run separately. Because the CI success is determined at the longest task (which is tesk-sdk and test-smoke), so by combing them together doesn't make the CI worst, IMO.

duc-nx commented 3 months ago

Updated the Cache and compare the test time between main and this branch:

Build time actually improved. (except tesk_smoke and test_sdk where we do a fresh build).

duc-nx commented 3 months ago

Close this PR due to no time to work on it anymore. Although the CI build is improved and Code scanning will be helpful to the project.