search

nexus511 / gpd-ubuntu-packages

This repository shall provide the base for building ubuntu packages from most of the patches currently used to get linux on the gpd-pocket.
GNU General Public License v3.0
73 stars 4 forks source link

Rotation is broken when wayland is used #39

Open cawilliamson opened 6 years ago

cawilliamson commented 6 years ago

Hey again,

I realise GNOME is mainly unsupported at this point (though your ISO works great!) but wanted to raise this one so others are aware.

I did see you have a gpdpocket-gnome-config package now so will look in to what that does and see if I can come up with a fix. I suspect it's just as simple as copying the monitors.xml to the gdm config directory but will create a PR with the fix if I find one.

nexus511 commented 6 years ago

I have merged some patches to the "gpdpocket-gnome-config" package that came with a PR. I have not double-checked, if those break something.

I am up to build new images soon, so I might take a look at this. Does the problem also occur on the "live-images" or only on the installed system?

cawilliamson commented 6 years ago

On the live images you're never prompted with a gdm prompt that I'm aware of since it only really happens at the login screen.

Should I be changing where I'm pointing apt to for this change? I've updated the gpdpocket-gnome-config package but no change to gdm as of yet.

cawilliamson commented 6 years ago

Hi @nexus511

I've finally had chance to look in to this and it turns out to be a simple fix:

Edit /etc/gdm3/custom.conf and uncomment #WaylandEnable=false - obviously this breaks Wayland but that sadly never did rotate properly even using monitors.xml for it.

May be worth adding this to your postinst script for gpdpocket-gnome-config - happy to add and submit a PR if that helps. Could always patch it back out later to re-enable Wayland support once rotation is fixed.

Herst commented 6 years ago

@cawilliamson Great! This is for 17.04? Will it also apply to 17.10? I don't think a PR for 17.04 would be useful.

cawilliamson commented 6 years ago

@Herst I haven't tested 17.10 yet (bit scared to break my install) but will take a backup and give it a shot over the weekend. I don't see any changes planned to Wayland in 17.10 though so I would assume so.

nexus511 commented 6 years ago

@cawilliamson I know that you had a patch in your ansible project that actually did this.

My feeling has been that wayland has been something that people want to use, so I actually tried to find a way to fix the configuration to properly support wayland.

There where rumors that wayland should be default for 17.10 and this makes it worse for upstream support. I will start working on 17.10 soon. Maybe I can just spend some time on it. I basically have the same problems as most around here: I have only one device and that makes it hard to test all the variants.

(Especially as the system should be installed as a proper test)

Herst commented 6 years ago

The wayland switch seems to be official; from https://didrocks.fr/2017/08/03/ubuntu--guadec-2017-and-plans-for-gnome-shell-migration/:

Oh, one last thing… we are going to switch over Wayland by default on 17.10. The Xorg session will still be available alongside. This enables us to get some good set of feedback to be ready and make our final decision for our next LTS, 18.04.

And https://didrocks.fr/2017/10/18/ubuntu-gnome-shell-in-artful-day-16/:

Any new Ubuntu installation will have two sessions available at most, whose base name is “Ubuntu”:

  • The “Ubuntu” session corresponds to GNOME Shell experience with our modifications (Ubuntu Dock, appindicator support, our theme, small behavior changes…). You have probably seen those and followed their development on previous blog posts. This is the default session running under Wayland.
  • The “Ubuntu on Xorg” session, being similar to the previous one, but running on Xorg as the name indicates :) Users who can’t run Wayland (using nvidia proprietary driver or unsupported hardware) should be automatically fallbacked and only presented with that session.

(Highlighting by me.)

nexus511 commented 6 years ago

@Herst okay. When we switch to 17.10. there needs to go some work in fixing the wayland configuration. Maybe I need to switch my device from 16.04. to 17.10. then to be able to debug those things.

android10 commented 6 years ago

Hello everyone! I can confirm that upgrading from 17.04 to 17.10 breaks landscape. It uses Wayland by default. You can double check by executing this:

echo $XDG_SESSION_TYPE

Any update on this? Is anyone running in the same situation?

@nexus511 thanks for such an amazing job!

cawilliamson commented 6 years ago

@android10 I have already submitted a PR with the fix for that issue.

@nexus511 - wayland does have severe performance issues with GNOME at the moment: https://bugzilla.gnome.org/show_bug.cgi?id=745032 - doesn't look to be an issue with the Pocket so much as a GNOME issue but just making you aware in case anyone reports it to you.

android10 commented 6 years ago

@cawilliamson awesome! Thanks!