search

nexus511 / gpd-ubuntu-packages

This repository shall provide the base for building ubuntu packages from most of the patches currently used to get linux on the gpd-pocket.
GNU General Public License v3.0
73 stars 4 forks source link

This enables middle button emulation without... #41

Open sigboe opened 6 years ago

sigboe commented 6 years ago

This enables middle button emulation without loosing functionality. You hold down right click to scroll with the trackpoint.

nexus511 commented 6 years ago

While it might be true that no functionality is lost for the middle mouse-button might be true, it is not for right-click scrolling.

The problem with this is that is breaks resizing of windows on tiling windows managers like awesome and i3. There you press and hold the right button to drag the window to proper size. As I know that people are using tiling window managers on the GPD to better use the small screen, I will not mess with this setting, as it will cause pain for them.

I might merge the middle mouse-button as it has been standard for other input devices in the past and should right the way it is provided.

sigboe commented 6 years ago

I didnt change the make.py file just because I didnt see how to edit two files just in the github webgui. Should be safe to merge, or just hold this PR open while you decide on what to do.

Oh yeah, and this only affects the built in trackpoint, no usb or bluetooth mouse. Right click scrolling is often an option in the gui of the driver of computers that has a trackpoint with only two buttons.

nexus511 commented 6 years ago

@sigboe To edit two files you need to checkout the code, perform the changes, commit it and use the patch to create a pull request. It is actually not necessary, as I see your point and can do it myself.

Maybe we can put this settings into another package that users can optionally install and will not get by default. I have been aware of this change to the Xorg settings, as it has been around on reddit for month but it is just breaking stuff for some people, so I cannot just merge it this way.

Better ideas to resolve this are always welcome.

sigboe commented 6 years ago

Adding it to a separate package is not so bad idea. Then it can be enabled or disabled by sudo apt-get {install,remove} package

This is separate in some ways to the old patch. I had problems with the old patch because it was ephemeral, so when the usb device lost power for any reason to be reconnected, like when sleeping or other weird situations, Id need to run the script with the commands again to apply the settings. This applies the settings when the device is connected, so its at boot or even after sleep.

I didn't know of any compatibility issues with awesome, I've only used i3 and to my knowledge how you can bind the mouse in i3 should not have compatibility issues with this (I may be wrong though).

fungi commented 6 years ago

Users can also simply add a line like this to their session initialization (it's what I do now):

xinput set-prop "pointer:SINO WEALTH Gaming Keyboard" "libinput Middle Emulation Enabled" 1
sigboe commented 6 years ago

@fungi I have done that before and needed to re run the command every time the computer woke from sleep.

The rule file applies the setting every time the device is connected.