Review adding depends_on to various base classes

nexusformat / NIAC

Issue for the NIAC to discuss (no code)

2 stars 0 forks source link

Review adding depends_on to various base classes #109

Closed benajamin closed 2 years ago

benajamin commented 2 years ago

@zjttoefs has prepared pull request definitions/#999 to add depends_on to many base classes. The NIAC decided to adopt a CIFS-style depends_on field in 2012, but without much guidance on the specific details of its use. This pull request provides clarity of usage by defining locations where a depends_on field could be written.

The pull request also updates the base classes by replacing the deprecated NXgeometry with NXtransformations.

benajamin commented 2 years ago

We reviewed the changes and it looks uncontroversial except maybe for the new images that specify details that haven't previously been approved by the NIAC.

benajamin commented 2 years ago

Proposal is to accept the pull request https://github.com/nexusformat/definitions/pull/999

benajamin commented 2 years ago

Implemented by https://github.com/nexusformat/definitions/pull/1091