search

nexusformat / NIAC

Issue for the NIAC to discuss (no code)
2 stars 0 forks source link

NeXus Ptychography discussion on geometry #53

Closed FreddieAkeroyd closed 3 years ago

FreddieAkeroyd commented 3 years ago

Proposed by @prjemian

prjemian commented 3 years ago

PJ mentioned that he has been approached regarding a NeXus ptychography format for reduced data and how best to describe e.g. beam centre x and y in NeXus. HB indicated that there are overlaps with NXmx and it would be good to have a common approach and terminology. It was agreed to discuss this at the NIAC/code camp. NIAC

prjemian commented 3 years ago

Nothing to vote on here, just make a recommendation.

prjemian commented 3 years ago

There is no consensus approach.

prjemian commented 3 years ago

Use NXtransformations to describe the position of the detector. Is there an example to follow?

phyy-nx commented 3 years ago

Example from XFEL: https://doi.org/10.5281/zenodo.3352357

prjemian commented 3 years ago

see https://manual.nexusformat.org/design.html#coordinate-transformations

yayahjb commented 3 years ago

The equivalent beam center code for CBF using the CBF coordinate system in https://github.com/yayahjb/cbflib/blob/master/src/cbf_simple.c in the routines cbf_get_pixel_coordinates, cbf_get_beam_center and related routines. -- Herbert

mkoennecke commented 3 years ago

I found some slides from the original suggestion. This has been heavily modified since and we based our decision on what is on github now. NXTransform.pdf rotcombi

prjemian commented 3 years ago

Additional notes for the ptycho community about the depends_on chain are placed in https://github.com/nexusformat/definitions/issues/864#issuecomment-740689052.

Thanks for the contributions!