Another contributions bug in the main branch

nexusformat / definitions

Definitions of the NeXus Standard File Structure and Contents

https://manual.nexusformat.org/

Other

26 stars 56 forks source link

Another contributions bug in the main branch #1162

Closed woutdenolf closed 2 years ago

woutdenolf commented 2 years ago

@prjemian @PeterC-DLS What should the "status" of a contributed definition be? At this point I'm using dev_tools to verify the main branch.

Current documentation

main branch

dev_tools branch

prjemian commented 2 years ago

I like that it shows the category (base or app def) but feel that since contributed are in some probationary status, that seems like an additional part of the status.

base class (contributed), extends [NXobject]
application definition (contributed), extends [NXobject]

woutdenolf commented 2 years ago

I like @prjemian 's suggestion but propose first to do https://github.com/nexusformat/definitions/pull/1163 which puts things back the way they were.

prjemian commented 2 years ago

My suggestion can wait until the next release. It joins many such nice things to have that will add delay to an immediate release.

PeterC-DLS commented 2 years ago

So revert to just category for time being?

PeterC-DLS commented 2 years ago

Ok, reassign to next milestone.