nexusformat / definitions

Definitions of the NeXus Standard File Structure and Contents
https://manual.nexusformat.org/
Other
26 stars 56 forks source link

1170 nxxas documentation improvement #1190

Closed benajamin closed 2 years ago

benajamin commented 2 years ago

fixes #1170 with minimal changes.

prjemian commented 2 years ago

Suggest adding some versioning information, such as this from NXentry: https://github.com/nexusformat/definitions/blob/78141ca792b602609e30852a54abf54fc7822ebc/base_classes/NXentry.nxdl.xml#L134-L153

prjemian commented 2 years ago

See #1038 for question on versioning

benajamin commented 2 years ago

Proposal is to accept the changes to NXxas in pull request #1190

padraic-shafer commented 2 years ago

Hi, I'm late to the party here but wanted to say that these look like positive changes, and I'd like to find a way to keep this list of NXxas/DATA/modes up-to-date.

In the near term, we would like to see "Luminescence Yield" added as option. I think it would it would be helpful to include an "OTHER" such as "Other Transmissive" and "Other Absorptive" as additional expansion options.

In the next month or so, we'll be submitting a follow-up enhancement of the NXxas definition that supports multi-detector measurements. Simply wanted to add a placeholder before anything gets backward incompatible.

Suggestions are welcome!