search

nexusformat / definitions

Definitions of the NeXus Standard File Structure and Contents
https://manual.nexusformat.org/
Other
26 stars 56 forks source link

Invalid units #1204

Closed TLCFEM closed 1 year ago

TLCFEM commented 1 year ago

https://github.com/nexusformat/definitions/blob/ea89964a412206b31e0b754bf95fad8e53f9650e/contributed_definitions/NXxpcs.nxdl.xml#L195

units=NX_INT is not a valid token for dimensionality. Guess it shall be NX_COUNT or something else.

prjemian commented 1 year ago

Thanks for reporting this! Yes, that's an oversight.NX_COUNT seems right, based on the docs.

PeterC-DLS commented 1 year ago

Also G2_unnormalized on L180 should not be dimensionless but NX_ANY

prjemian commented 1 year ago

@PeterC-DLS I agree. Without the denominator, the units no longer cancel.