Apparent advice loop: NXaperture and NXslit

nexusformat / definitions

Definitions of the NeXus Standard File Structure and Contents

https://manual.nexusformat.org/

Other

26 stars 56 forks source link

Apparent advice loop: NXaperture and NXslit #1231

Closed paulmillar closed 7 months ago

paulmillar commented 1 year ago

I noted that the definition of NXaperture says:

A beamline aperture. This group is deprecated, use NXslit instead

while the definition of NXslit says:

A simple slit. For more complex geometries, NXaperture should be used.

This appears (to me) to be a loop, leaving it unclear how to represent "complex" geometries.

benajamin commented 8 months ago

I suspect that this is a mistake and it NXslit that was meant to be deprecated. The deprecation text was added in pull https://github.com/nexusformat/definitions/pull/1091, which is not related to deprecating NXaperture.

phyy-nx commented 8 months ago

See b5ed52b1edac60b4e8ccddcb376d569f0e52cdfb

phyy-nx commented 8 months ago

From Telco Jan 17 2024

Undeprecate NXaperture and clarify the reason why (it was probably documented as deprecated by mistake, and it remains in common usage in various NXbase classes and application definitions) (this is a documentation bug but vote anyway, @phyy-nx)
Add a field SHAPE of class NXoff_geometry (addition to base class needs a vote, @phyy-nx)
Fix typo, extra "*" at the end of the NOTE field (@prjemian)