nexusformat / definitions

Definitions of the NeXus Standard File Structure and Contents
https://manual.nexusformat.org/
Other
26 stars 55 forks source link

Allow float data for NXtomo and NXtomoproc #1241

Open samtygier-stfc opened 1 year ago

samtygier-stfc commented 1 year ago

This is a follow on from a discussion stated on mailing list.

I am working on Mantid Imaging which features reading and writing of neutron imaging data from NXtomo and NXtomoproc.

While the data from the instrument usually arrives as uint16 we do our processing in, and reconstruct to float32. The NXtomoand NXtomoproc definitions both specify the imaging data array as NX_INT. Ideally, we'd like to be able to store our datasets in float32, both for reconstructed output and intermediate processed projections. We do this with TIFFs and it avoids any loss of precision.

I propose that NXtomo/entry/instrument/detector/data and NXtomoproc/entry/data/data have their types changed to NX_NUMBER

mkoennecke commented 1 year ago

For NXtomoproc this is a reasonable request. For NXtomo I would need a detector which spits out floats to convince me.

samtygier-stfc commented 1 year ago

For NXtomo we'd use this when a user wants to save a dataset that has had some processing applied to it but has not been reconstructed. Is it not maybe right to put this back into NXtomo/entry/instrument/detector/data?