search

nexusformat / definitions

Definitions of the NeXus Standard File Structure and Contents
https://manual.nexusformat.org/
Other
26 stars 55 forks source link

Adds git based versioning for `get_nxdl_version` #1318

Open domna opened 8 months ago

domna commented 8 months ago

We started to add a version based on the git tag and hash in pynxtools (see https://github.com/FAIRmat-NFDI/pynxtools/pull/124) and I thought could be useful as a general feature. This PR is just to start a discussion whether it is desired to have a versioning like this in this repository, too.

When a git repository is available it constructs a version string based on the last tag, commit distance and commit hash. If no repository is available this falls back to reading NXDL_VERSION.

domna commented 5 months ago

Currently it's failing because it needs reformatted according to black>24. This will be fixed by #1344

PeterC-DLS commented 5 months ago

You need to rebase to the tip of main for the fixed formatting of xsd_units.py

PeterC-DLS commented 5 months ago

And then format your altered file

domna commented 5 months ago

And then format your altered file

That's the grouping of the subprocess imports. It seems like isort doesn't like them being grouped