Open phyy-nx opened 5 months ago
691f56a addresses comments from the review of #1333:
Thanks for the feedback! This is ready for further review :)
@paulmillar @PeterC-DLS I've come back to this after a while and responded to your comments. Can you review and resolve the comments that are ok now?
Also, I'm not seeing why the checks are failing. Any help on this @PeterC-DLS?
Thanks!!
Feedback from Telco: need to deprecate NXdata's scaling_factor and offset instead of replacing them with FIELDNAME_scaling_factor and FIELDNAME_offset
Woops I actually had deprecated the original fields. So @paulmillar and @PeterC-DLS this is ready to review. Thanks!
Adds
FIELDNAME_scaling_factor
andFIELDNAME_offset
as fields to NXdata. These fields should be used instead ofscaling_factor
andoffset
, as it is ambiguous which fields to apply them to in the case of multiple signals._scaling_factor
and_offset
are added as reserved suffixes.Additionally adds a formula for how to apply these fields:
For NXmx, adds clarification these fields can be used as pedestal and gain correction fields, and defines these terms. Also the possible rank options are elaborated. These rank options were implied (in my opinion) in the original wording, but in NXmx I made it more explicit.
Closes #1332. Same set of changes as in #1333 with an additional commit to resolve feedback from #1333.