search

nexxai / CryptoBlocker

A script to deploy File Server Resource Manager and associated scripts to block infected users
GNU General Public License v2.0
200 stars 73 forks source link

Submit form now has a mandatory E-Mail field #41

Closed gizmo21 closed 6 years ago

gizmo21 commented 6 years ago

Why is it needed to now a e-mailAdress at submission, where even the placeholder still says "optional"? I gladly help adding to this list and URL wehre to find makes sense, but why do you need the mail adress. Having to fill in Fake-Adresses otherwise.

If I use the form without email address, i am given: "The email address must be a valid email address."

nexxai commented 6 years ago

This is unintentional - email addresses should certainly be optional. I'm not sure what changed but I'm looking at it right now and will figure out why it's making them mandatory.

nexxai commented 6 years ago

@gizmo21 This should be fixed now. It looks like when we upgraded the site to use the newest version of the framework, there were some subtle changes to how validation on form fields work. Specifically, until recently, you didn't have to specify that a field was allowed to be "null"; if you didn't specify "required", it would assume "nullable" is the correct option. Now, it looks like the default setting is "required" and allowing a nullable field has to be specifically defined.

I apologize for the confusion.

gizmo21 commented 6 years ago

Thx for the fix, the service itself and I will be submitting in future. thumbs-up